aldy505
/
jokes-bapak2
mirror of https://github.com/aldy505/jokes-bapak2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: handle empty data set

This commit is contained in:
Reinaldy Rafli 2021-07-17 17:34:02 +07:00
parent a60c7b91cc
commit 19ca25eb5b
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
api/app/v1/core/jokes.go
View File

@ -45,7 +45,12 @@ func GetRandomJokeFromCache(memory *cache.Cache) (string, error) {
return "", nil return "", nil
} }
random := rand.Intn(len(data)) dataLength := len(data)
if dataLength == 0 {
return "", models.ErrEmpty
}
random := rand.Intn(dataLength)
joke := data[random].Link joke := data[random].Link
return joke, nil return joke, nil

1
api/app/v1/models/sql.go
View File

@ -7,3 +7,4 @@ var ErrConnDone = errors.New("connection is already closed")
var ErrTxDone = errors.New("transaction has already been committed or rolled back") var ErrTxDone = errors.New("transaction has already been committed or rolled back")
var ErrNotFound = errors.New("record not found") var ErrNotFound = errors.New("record not found")
var ErrEmpty = errors.New("record is empty")